Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: go oss (#63) follow-up nits #64

Merged
merged 6 commits into from
Apr 26, 2024
Merged

chore: go oss (#63) follow-up nits #64

merged 6 commits into from
Apr 26, 2024

Conversation

babblebey
Copy link
Member

@babblebey babblebey commented Apr 26, 2024

Description

This Pull request implements some tiny changes carried over from #63 and addresses some todo that are simple enough.

Changes Made

  • Implemented the submission visual cue on the word editor - this turns the submission loading button green after a word submission is successfully done before the redirection to he jargons editor dashboard
  • Added "babblebey" to funding/sponsor this project section
  • Extracted addToRecentSearches logic from search to word.astro layout - this ensures that words are added to recent searches when viewed and not only when they are searched using the search feature

Related Issue

Screenshots/Screencasts

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.04.26-21_45_48.webm

Notes to Reviewer

NA

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jargons-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 8:20pm

@babblebey babblebey changed the title Chore/nits#2 chore: go oss #63 follow-up nits Apr 26, 2024
@babblebey babblebey changed the title chore: go oss #63 follow-up nits chore: go oss (#63) follow-up nits Apr 26, 2024
@babblebey babblebey merged commit 525d2b2 into main Apr 26, 2024
2 checks passed
@babblebey babblebey deleted the chore/nits#2 branch April 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Search Operation Performed with Search Form in Navbar Overwrites LocalStorage
1 participant