-
Notifications
You must be signed in to change notification settings - Fork 40
Adding quantile types #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added feature to specify quantile types. Includes changes in: - Interface - Quantiles in descriptives table - IQR in descriptives table - Boxplots - QQ-plots
Adding reference for help documentation
Some more explanations for the help file and clean-up.
- Code for treating ordinal variables as continuous to use the same quantile type for ordinal as well as continuous variables - Additional resource for help file - Making sure unit test for ordinals uses type 3 as the unit test was written under this assumption
| label: qsTr("Type") | ||
| id: quantilesType | ||
| indexDefaultValue: 6 // Type 7, the default in R | ||
| info: qsTr("Method used to compute quantiles (see Hyndman & Fan, 1996; Langford, 2006, for more information). The selection carries over to the inter-quartile range (IQR), box- and QQ-plot calculations. Note that ordinal variables are treated as continuous for the computations.\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps also mention which values corresponds to other software programs? because the help file will be generated from this if I remember correctly, so it might be nice to mention this there as well.
| {label: qsTr("4"), value: 4}, | ||
| {label: qsTr("5"), value: 5}, | ||
| {label: qsTr("6 (Minitab, SPSS)"), value: 6}, | ||
| {label: qsTr("7 (R, S)"), value: 7}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {label: qsTr("7 (R, S)"), value: 7}, | |
| {label: qsTr("7 (R)"), value: 7}, |
I'd be inclined to omit S since it's been superseded by R.
Allowing user to specify the type for the quantile estimation.