Cache API calls to fetch watching repos #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the performance of
SystemStreamWatchingClient.buildSearchQueries.Problem
SystemStreamWatchingClient.buildSearchQueriesis a bottleneck in my environment because I have 1000+ watching repositories so it calls the API 10+ times.buildSearchQueriesis called for each iteration, which means it is called many times.Solution
Cache the API calls. By this change,
buildSearchQueriesreturns from the cache, and the cache expires in 10 minutes.It has also a disadvantage, which it introduces a 10mins delay to update the watching repositories.
But I think it is not a problem. Probably, the users don't expect to synchronize the watching repositories immediately. So the delay is acceptable.
This change has a large impact on me. I'd be very happy if this change is accepted.