Classifications repeated scores fix#170
Merged
jatkinson1000 merged 3 commits intoagb-2026-classificationsfrom Apr 8, 2026
Merged
Classifications repeated scores fix#170jatkinson1000 merged 3 commits intoagb-2026-classificationsfrom
jatkinson1000 merged 3 commits intoagb-2026-classificationsfrom
Conversation
d954bb5 to
2b5f3a4
Compare
…scores and fixes.
…ange is U12 Longbow New Warwick.
…B classifications.
2b5f3a4 to
9047bf8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## agb-2026-classifications #170 +/- ##
============================================================
+ Coverage 98.30% 98.31% +0.01%
============================================================
Files 34 34
Lines 2355 2373 +18
============================================================
+ Hits 2315 2333 +18
Misses 40 40
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
There is a possibility for scores in tables to be repeated if both handicap thresholds fall with 2 scores that are only 1 point apart.
This fixes that by enforcing that all scores be at least 1 point above the previous classification score.
Applied to all 'new' classifications (indoor, outdoor, field), but only affects the New Warwick table for Under 12 Longbow.