Skip to content

Conversation

@Iamleos
Copy link
Contributor

@Iamleos Iamleos commented Nov 19, 2025

add sglang-jax refer to README.md

Reference

Checklist

  • I have read the Contribution Guidelines and used pre-commit hooks to format this commit.
  • I have added all the necessary unit tests for my change. (run_model.py for model usage, test_outputs.py and/or model_validation_colab.ipynb for quality).
  • (If using an LLM) I have carefully reviewed and removed all superfluous comments or unneeded, commented-out code. Only necessary and functional code remains.
  • I have signed the Contributor License Agreement (CLA).

@google-cla
Copy link

google-cla bot commented Nov 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Iamleos Iamleos force-pushed the feat/add_sgl-jax_refer branch from 489dafb to c9dd9cb Compare November 19, 2025 08:22
@Iamleos
Copy link
Contributor Author

Iamleos commented Nov 19, 2025

cc @jenriver

@jenriver
Copy link
Member

jenriver commented Dec 5, 2025

Hello Iamleos,

We are very excited about the potential of sglang-jax, but our understanding is that it remains a new project under active development and has not yet achieved widespread industry adoption.

While we are happy to use Bonsai as a repository for the simple implementation and quality baseline of models used in sglang, I suggest we wait until sglang-jax is more battle-tested before generically recommending it here. What do you think?

@jenriver
Copy link
Member

jenriver commented Jan 9, 2026

Hi @Iamleos, thanks for the contribution in umT5!

We are very interested in supporting sglang for the JAX community. Having ground truth model implementations in Bonsai would be incredibly valuable for testing parity with sglang-jax models.

Please let us know how we can best support you as you continue these implementations. We’re happy to help with any questions or specific needs where the Bonsai team can be of assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants