Skip to content

Add .editorconfig #16240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Add .editorconfig #16240

merged 1 commit into from
Jun 5, 2023

Conversation

NeilGirdhar
Copy link
Contributor

@NeilGirdhar NeilGirdhar commented Jun 2, 2023

The editorconfig file helps non-Googler contributors who have their editors set up differently for different projects. Most modern editors will automatically use the Google style when they see this file:

  • (most importantly) 2 character indent size,
  • 79 character maximum line length,
  • spaces instead of tabs,
  • linux line endings, and
  • no extraneous whitespace.

This file helps non-Googler contributors who have their editors set up
differently for different projects.  Most modern editors will
automatically use the Google style when they see this file:
* (most importantly) 2 character indent size,
* 79 character maximum line length,
* spaces instead of tabs,
* linux line endings, and
* no extraneous whitespace.
@froystig froystig requested a review from jakevdp June 3, 2023 00:56
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Jun 5, 2023
@jakevdp jakevdp removed the pull ready Ready for copybara import and testing label Jun 5, 2023
@jakevdp jakevdp self-assigned this Jun 5, 2023
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Jun 5, 2023
copybara-service bot pushed a commit that referenced this pull request Jun 5, 2023
FUTURE_COPYBARA_INTEGRATE_REVIEW=#16240 from NeilGirdhar:editorconfig 4b3f73a
PiperOrigin-RevId: 537816351
@copybara-service copybara-service bot merged commit f2f49cf into jax-ml:main Jun 5, 2023
@NeilGirdhar NeilGirdhar deleted the editorconfig branch June 5, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants