Fix #38 -- Return 400 if the given step is not found#47
Open
gchp wants to merge 1 commit intojazzband:masterfrom
Open
Fix #38 -- Return 400 if the given step is not found#47gchp wants to merge 1 commit intojazzband:masterfrom
gchp wants to merge 1 commit intojazzband:masterfrom
Conversation
|
LGTM |
jsma
added a commit
to jsma/django-formtools
that referenced
this pull request
Oct 29, 2022
Previously, bots could and would stuff this form value with all kinds of nonsense, triggering a server error (and subsequent alert emails). Supersedes jazzband#47
|
If a client requests a non-existing step it technically is a BadRequest but there are situations in which it is not the client's fault. For example, if conditional steps are involved and a condition for a step is not met anymore although a client already began a session in which they are currently at the now missing step In this case I personally find it more helpful to redirect the client to the first step than to return a status code 500 (current behaviour) or 400. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.