fix: use floating events if not tz is set #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigenmannmartin
force-pushed
the
feat/broken-floating
branch
from
8b2e1fc to
f6d97ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 91.22% 91.82% +0.59%
==========================================
Files 4 4
Lines 376 379 +3
Branches 98 100 +2
==========================================
+ Hits 343 348 +5
+ Misses 14 13 -1
+ Partials 19 18 -1 ☔ View full report in Codecov by Sentry. |
eigenmannmartin
commented
Sep 1, 2024
eigenmannmartin
commented
Sep 8, 2024
| @@ -22,7 +22,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install poetry==1.1.11 | |||
| pip install poetry==1.8.3 | |||
There was a problem hiding this comment.
why: updated poetry
eigenmannmartin
commented
Sep 8, 2024
| @@ -179,7 +180,16 @@ def create_event(component, utc_default): | |||
| event.start = component.get("dtstart").dt | |||
| # The RFC specifies that the TZID parameter must be specified for datetime or time | |||
| # Otherwise we set a default timezone (if only one is set with VTIMEZONE) or utc | |||
| event.floating = type(component.get("dtstart").dt) == date and utc_default | |||
| if not strict: | |||
There was a problem hiding this comment.
Why: allow backward compatibility
eigenmannmartin
commented
Sep 8, 2024
| @@ -323,15 +333,14 @@ def parse_events( | |||
|
|
|||
| found = [] | |||
|
|
|||
| def add_if_not_exception(event): | |||
| def is_not_exception(date): | |||
There was a problem hiding this comment.
Why: less out of scope variable access
eigenmannmartin
commented
Sep 8, 2024
| if not event.recurrence_id and (event.uid, event.start) in [ | ||
| (f.uid, f.recurrence_id) for f in found | ||
| ]: | ||
| if not event.recurrence_id and ( |
There was a problem hiding this comment.
Why: black wanted it to reformat
eigenmannmartin
force-pushed
the
feat/broken-floating
branch
from
c3d06fa to
fb1f99c
Compare
eigenmannmartin
commented
Sep 8, 2024
| @@ -795,3 +835,29 @@ def test_multi_exdate_same_line(self): | |||
| self.assertEqual(evs[3].start, datetime(2022, 4, 22, 11, 0, 0, tzinfo=tz)) | |||
| self.assertEqual(evs[4].start, datetime(2022, 4, 29, 11, 0, 0, tzinfo=tz)) | |||
| # parsing stops at 2022-05-01 | |||
|
|
|||
| def test_google_2024(self): | |||
There was a problem hiding this comment.
Why: google changed it's ics output and now includes timezones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done: