Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition always true #148

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Condition always true #148

merged 1 commit into from
Jan 17, 2025

Conversation

McLaynV
Copy link
Contributor

@McLaynV McLaynV commented Jan 11, 2025

This condition is always true, so it does not make any sense to have it there.

On the same line, I would also consider replacing if sort is True: -> if sort:.

@DerDreschner DerDreschner merged commit 8a65dc6 into jazzband:master Jan 17, 2025
2 checks passed
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (4d29ced) to head (97c73ba).
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   91.82%   91.79%   -0.03%     
==========================================
  Files           4        4              
  Lines         379      378       -1     
  Branches      100      100              
==========================================
- Hits          348      347       -1     
  Misses         13       13              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@McLaynV McLaynV deleted the always-true branch January 17, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants