Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.github/workflows/build.yml] enable to run of test at the 'windows-latest' environment. #1074

Merged
merged 1 commit into from
Dec 15, 2021
Merged

[.github/workflows/build.yml] enable to run of test at the 'windows-latest' environment. #1074

merged 1 commit into from
Dec 15, 2021

Conversation

TheVice
Copy link
Contributor

@TheVice TheVice commented Dec 15, 2021 •
edited
Loading

Hello.

This request fix all know issues that was detected while run pipeline at the Windows platform:

  • dll was not placed near to the test binary, so ctest tool could not execute a binary;
  • used std::isspace with non 'unsigned char' type of argument do not pass assert check at MSVC environment, but such casting should be provided for all environments according to documentation on that function.

This request partially replace #1057 - only enabling to run at macOS left there.

Thank you.

@TheVice
[MSVC|CMakeLists.txt] added copying of shared library
963e7a9 
to the output directory with a test binary.

[binary] removed using of non unsigned char as argument at
'std::isspace' function that was provokes undefined behavior.

[.github/workflows/build.yml] enabled run of test at the
'windows-latest' environment.
@jbeder jbeder merged commit d8d9419 into jbeder:master Dec 15, 2021
@TheVice TheVice deleted the msvc branch December 16, 2021 01:45
davemccann pushed a commit to davemccann/yaml-cpp that referenced this pull request Jul 30, 2023
@TheVice @davemccann
Fix shared library tests for Windows (jbeder#1074)
4e6c404 
Add copying of shared library to the output directory with a test binary.

[binary] removed using of non unsigned char as argument at
'std::isspace' function that was provokes undefined behavior.

[.github/workflows/build.yml] enabled run of test at the
'windows-latest' environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbeder jbeder jbeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheVice @jbeder