-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove build debug messages #1316
Conversation
@jbeder please review |
I'm not sure I understand this; aren't they already essentially commented with the #pragma? |
This is how the build looks like:
|
Sorry, I meant that it doesn't actually affect the build (outside of the message). It sounds like you don't want the message? I suppose we can delete it if you like. Why comment it out? |
I thought maybe you would want it for debugging the build. If you don't care about it, I'll delete it. |
5f388ea
to
9e62b7c
Compare
Done |
They pollute the build output. Upstream PR: jbeder/yaml-cpp#1316 Change-Id: Ib3a72a1c92c878b2b1d18cb95e588dba7b166395 Reviewed-by: Eike Ziller <[email protected]> Reviewed-by: hjk <[email protected]>
They were commented out before 0733aeb, but when that commit was reverted in 2b65c65 they were recovered uncommented.