Skip to content

Add user input ramcloud locator and database name for test cases #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HarryWei wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add user input ramcloud locator and database name for test cases #2

HarryWei wants to merge 5 commits into from

Conversation

@HarryWei
Copy link
Contributor

@HarryWei HarryWei commented Apr 24, 2015

We cannot free conn in function sqlite3_rcvfs_disconnect untill we are sure it is not null.

@jblomer
Copy link
Owner

jblomer commented Apr 24, 2015

Why should conn be NULL at this point?

@HarryWei
Copy link
Contributor Author

HarryWei commented Apr 24, 2015

Hi Jakob,
Yes, it seems conn would not be NULL here. I just think it is safer to check NULL before free it. Anyway, this pull is really trivial ;-)
BTW, I find sqlite3_rcvfs_refresh_leases is in our TODO list and I could try to realize it, any comments?

Thanks very much, Weiwei

@HarryWei HarryWei changed the title Check not null before free memory Add user input ramcloud locator and database name for test cases Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HarryWei @jblomer