Conversation
halium-install
Outdated
| if [ $FLASH_ADB ]; then | ||
| flash_error flash_adb | ||
| else | ||
| flash_error flash_rsync |
There was a problem hiding this comment.
Where are the parameters 'flash_adb' and 'flash_rsync' used?
There was a problem hiding this comment.
The flash_error functions calls the flash_rsync function
functions/core.sh
Outdated
| function flash_error() { | ||
| if ! $1; then | ||
| echo "Error: Couldn't copy the files to the device, is it connected?" | ||
| fi |
There was a problem hiding this comment.
What should happen, if there is a first argument?
There was a problem hiding this comment.
This function prints the error message if the function it calls (argument) fails
functions/misc.sh
Outdated
| echo "[Debug] rootfs: $ROOTFS_TAR" | ||
| echo "[Debug] android image: $AND_IMAGE" | ||
| echo "[Debug] release: $ROOTFS_RELEASE" | ||
| echo "[Debug] install method: $FLASH_METHOD" |
There was a problem hiding this comment.
As you spelled [install] without capital letters, you should do it the same way here.
| } | ||
|
|
||
| function flash_rsync() { | ||
| TARGET_ARCH=$(adb shell uname -m) |
There was a problem hiding this comment.
Not a fix for that yet: On ilyabizyaev's device, uname -m reports i686
There was a problem hiding this comment.
Theoretically, you could just replace all i*86 architectures with i386 (or x86)
There was a problem hiding this comment.
I wanted to have a solution without mapping different architecture shemes, but as their doesn't seem to be one, I'll probably do it like that.
| echo "Debug: Chosen release is $ROOTFS_RELEASE" | ||
| echo | ||
| # Print out useful debugging information | ||
| [ $DEBUG == "true" ] && debug_variables |
There was a problem hiding this comment.
Just an idea, you could call it verbose mode
2 participants
Needs testers, but works on my device already
If you test this, please tell me whether it's faster or slower than ADB?
And sorry, this is currently only working on arm devices for the simple reason that I haven't found a good way to detect the architecture. For intel, you need to replace arm by x84 in the rsync download link manually.
You can still use ADB on this branch if you set
FLASH_METHOD=ADBas environment variable.TODO: