I made some change. Please review whether the change is suitable. #3
Conversation
derjohng
commented
Aug 20, 2014
derjohng
commented
- Major, I add "Today stock price" feature.
- Change iOS6, AFNetwork1.3.x support. (But, I am not sure whether that will cause AFNetwork 2.x not work??)
- Reorder "5 year/1year/..." to "1 week/month/..."
2. Disable the Cache.
2. Adjust the position of "1 week" labels inside Graph.
…raphs getData at the same time.
|
Some of these changes are definitely good, but there are some that I don't necessarily want to merge into master. For example, there were breaking changes from AFNetworking 1.x -> 2.x, so if I had to choose I would rather support 2.x. Furthermore, you've done some things like disable caching by default which I would definitely prefer to be enabled by default. I can address these issues myself, or you could if you'd like. Could you perhaps explain the "Today stock price" feature you mentioned? It's not immediately clear to me what you mean by this. |
|
ichart.finance.yahoo.com/table.csv only provide the prices till yesterday, not include today's price. So, I supplement today price from download.finance.yahoo.com/d/quotes.csv. |
|
Ah, I see, very good. I had considered doing that as well, glad you've implemented it. I'll have to address these changes soon. |
2 participants
