Merged
Conversation
- Optimistically update UI pendingBets locally when a bet is placed to avoid gap before tx mines - Wait for mined transaction receipts (tx.wait()) for both placeBet and executeWager before using latest block number - Use receipt.blockNumber to trigger refreshes, eliminating undefined blockNumber bug - Refresh balances and pending bets after confirmation ensuring real-time UI updates - Adds in-progress TODO list and setup docs in previous commits but included here to keep branch consistent
…e.sol tests Changes: - contracts/Roulette.sol: add _house address, track totalStake, transfer losing bets to house, fix payable cast. - src/test/contracts/Roulette.js: begin migration to new constructor and bet requirement; added helper functions placeBetForPlayer and spinWithBet; updated first set of tests to new event signature. Remaining work: - Finish refactoring all test cases to use helpers and correct assertion flow. - Update any other test files that interact with Roulette contract. - Re-run test suite until all passing.
- Merge updateContractAddresses.js functionality into initializeChain.js - Add _updateBlockchainWrapperAddresses() function to automatically update contract addresses in blockchainWrapper.js after deployment - Remove separate update-addresses npm script from package.json - Simplify setup workflow to use single init-chain command - Delete redundant scripts/updateContractAddresses.js file This change streamlines the setup process by eliminating the need for a separate address update step, making the workflow more reliable and user-friendly. The init-chain script now handles both contract deployment and address updating in one seamless operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.