qualify command 'i' value before setting node id#80
Open
pb66 wants to merge 2 commits intojeelabs:masterfrom
Open
qualify command 'i' value before setting node id#80pb66 wants to merge 2 commits intojeelabs:masterfrom
pb66 wants to merge 2 commits intojeelabs:masterfrom
Conversation
A stray "i" can attempt to set a node id of "0" and result in a "config save failed" although setting the node id to "0" will of succeeded and the result is no further packets will be processed until a valid node id is set.
Collaborator
|
Node == 0 is also used to disable interrupts from the radio. The config save failed error message isn't a desirable outcome but interesting point as to which facet ought to be fixed. |
setting node id == 0 is used to disable interupts from the radio module, using 32i has the same effect due to bit masking without the vulnerability of accidental activation by value omission assumed to be 0.
Author
|
I wasn't aware of the "interrupt disable" feature so will leave the decision to your better judgement. I have however amended my code to allow > 0 <33 so that 32i could be used as a "interrupt disable" instead, with a significant reduction in potential accidental activation. Perhaps the "current configuration" string could be appended to (or even replace) the "config save failed" message to help identify if node 0 is selected, it would be more consistent to provide the "current config" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stray "i" can attempt to set a node id of "0" and result in a "config save failed" although setting the node id to "0" will of succeeded and the result is no further packets will be processed until a valid node id is set.