-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add More 50xx series, and add copy paste templates for adding more links #3191
base: main
Are you sure you want to change the base?
Conversation
I attempted to build this from the docker file to test it (read: run it early) and I am getting the following error when building the docker image:
I have no issue building from jef's main branch. |
@JDIacobbo So sorry I mistyped something in the code.. I will update that right now |
Try Now? I may need to revamp my ubiquity changes |
Still won't compile with the same error. |
Another absolute banger!!! Thank you 🙏 😍 |
Looks like @JDIacobbo is right. Let me know if you need any help! |
@@ -39,6 +39,12 @@ DISCORD_NOTIFY_GROUP_RYZEN5600= | |||
DISCORD_NOTIFY_GROUP_RYZEN5800= | |||
DISCORD_NOTIFY_GROUP_RYZEN5900= | |||
DISCORD_NOTIFY_GROUP_RYZEN5950= | |||
DISCORD_NOTIFY_GROUP_RYZEN7800X3D= | |||
DISCORD_NOTIFY_GROUP_RYZEN9800X3D= | |||
DISCORD_NOTIFY_GROUP_RYZEN9600= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can I make a nit about these? Are the models 9600 or 9600X? I think the same applies for the other models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch they are x variants, not non x. I'll fix that when I'm at my desk next
src/store/model/newegg.ts
Outdated
'https://secure.newegg.com/Shopping/AddtoCart.aspx?Submit=ADD&ItemList=N82E16814137919', | ||
model: 'gaming trio oc', | ||
series: '5090', | ||
url: 'https://www.newegg.com/pN82E16814137919', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in this line (1647). You are missing a /
after the p
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@jef ok so I remove all my UI stuff because of a bug I found. I will make that a separate PR. However regarding the discrepancy with the 9600 vs non x version, I dont think the 5000 series differentiated the two which is why I did it the way I did. It should be good now |
@JDIacobbo I found and fixed the bug. see this |
As stated in the title I added 50 series links for Bestbuy, Newegg, Pny, and Zotac. I also added some AMD CPUs. I also made copy paste templates at the bottom so it is easier to bulk add cards. The biggest thing was adding all of the Ubiquiti Switches, Cameras, Wifi, and Firewalls.
Enjoy!