This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Fixed undesired line breaks and Markdown syntax for Links.#84
Open
a-inacio wants to merge 1 commit intojeffkowalski:masterfrom
Open
Fixed undesired line breaks and Markdown syntax for Links.#84a-inacio wants to merge 1 commit intojeffkowalski:masterfrom
a-inacio wants to merge 1 commit intojeffkowalski:masterfrom
Conversation
The mentioned line breaks where corrupting URLs, after some default line length, so text was being split into lines automatically (and therefore corrupting URLs). Links of type [http://someurl.com](http://someurl.com) can be expressed as <http://someurl.com>, so we have to tell the markdown processor to handle it like such.
Owner
|
@AntonioInacio, thanks for the fixes. You'll see that the tests are now failing, though. Would you correct the errors, and also maybe insert a new test that exercises your changes? |
Author
|
Upps sorry about that! Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I fixed some minor bugs that were preventing me to be able to use geeknote properly, hope you find then useful as well.
Cheers
More information here (from the commit message):