Fixes #115
Merged
Fixes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
commented
Jan 31, 2020
| @@ -80,14 +80,19 @@ def rendered_markdown(string) | |||
| end | |||
|
|
|||
| def formatted_body(body, type) | |||
| return body if body == " " | |||
| return body if body == "[binary data]" # see https://github.com/zipmark/rspec_api_documentation/blob/560c3bdc7bd5581e7c223334390221ecfc910be8/lib/rspec_api_documentation/client_base.rb#L88-L96 | |||
There was a problem hiding this comment.
the "[binary data"] change was related in our app to changing from - rack (2.0.8) to rack (2.1.1)
There was a problem hiding this comment.
bf4
commented
Jan 31, 2020
| raise JSON::ParserError | ||
| rescue => e | ||
| if Apitome.configuration.formatted_body_error_handler | ||
| Apitome.configuration.formatted_body_error_handler.call(e, body, type) |
bf4
commented
Jan 31, 2020
| <% | ||
| rescue => e | ||
| if Apitome.configuration.example_error_handler | ||
| Apitome.configuration.example_error_handler.call(e, "request", request) |
bf4
commented
Jan 31, 2020
| <% | ||
| rescue => e | ||
| if Apitome.configuration.example_error_handler | ||
| Apitome.configuration.example_error_handler.call(e, "response", request) |
bf4
commented
Jan 31, 2020
| @@ -0,0 +1,3 @@ | |||
| //= link apitome/application.css | |||
| //= link apitome/application.js | |||
| //= link apitome/highlight_themes/default.css | |||
bf4
referenced
this pull request
in zipmark/rspec_api_documentation
Jan 31, 2020
Do not display binary data in generated documentation. Closes #199.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no tests at this time.. just review for the shape of it, breaking it up, whatever
Fixes