Address Sass global function deprecation warnings #849
+72
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Chamberlain <[email protected]>
Deprecation warnings: - Deprecation Warning [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0. More info and automated migrator: https://sass-lang.com/d/import Migrate to use of '@use', '@forward', and '@include' instead Signed-off-by: David Chamberlain <[email protected]>
Deprecation warnings: - Deprecation Warning [global-builtin]: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0. Use color.adjust instead. - Deprecation Warning [color-functions]: lighten() is deprecated. - Deprecation Warning [color-functions]: darken() is deprecated. Use 'color.adjust' instead to preserve existing behavior Signed-off-by: David Chamberlain <[email protected]>
|
Hello @chaoscommencer, thank you for submitting this pull request. However, this is a non-backwards compatible change and therefore not within the scope of the 2.x series. However, this change isn't acceptable on the I won't be closing this right away but keeping it in limbo for the distant future. |
|
No problem; I have notifications on in case you would like assistance with this later. I think I saw a similar pull request open for the master branch already. This one of course only applies to the 2.5-stable branch. Have a good one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation warnings:
Use color.adjust instead.
NOTE: 'color.adjust' is used instead to preserve pre-existing behavior
NOTE: This version of the change requires changes 519c8ee - 2074190 from the pull request addressing use of
@import