Skip to content

Conversation

@timja
Copy link
Member

@timja timja commented Dec 20, 2025

See jenkinsci/credentials-plugin#984

Running full set of tests then I'll revert the local override so it can be merged

Testing done

Ran credentials plugin locally:

The two failures were weird frameworky issues, they passed on re-run.
image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

private static final String CRED_USER = "user";
private static final String CRED_PWD = "password";
private static final String CRED_DESCR = "descr";
private static final String CRED_DESCR = "My-super-unique-description";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if the tests used ID for locating the credentials but since its not I was a bit worried that this could end up not being unique enough so I just made it more specific, can drop this though.

@timja timja marked this pull request as ready for review December 21, 2025 08:06
@timja timja requested a review from a team as a code owner December 21, 2025 08:06
@timja timja merged commit 878e5be into jenkinsci:master Dec 27, 2025
20 of 23 checks passed
@timja timja deleted the adapt-credentials-plugin-for-cards branch December 27, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant