-
Notifications
You must be signed in to change notification settings - Fork 384
Add GitHub branch and pull request info to the 'Details' widget #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/main/java/org/jenkinsci/plugins/github_branch_source/ScmDetailGroup.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubCommitDetail.java
Show resolved
Hide resolved
|
Opening for review to get thoughts. Is the information we show the right information - e.g. is commit hash needed? Is my usage of the API correct/are there more efficient ways of doing this. |
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubRepositoryDetail.java
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubRepositoryDetail.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubCommitDetail.java
Show resolved
Hide resolved
timja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, would be nice if some of this could be centralised in e.g. git plugin or scm-api but I think its difficult because of all the special casing needed by pull requests.
I think there should be some test coverage though.
|
Good for review, will need squashing. |
src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubCommitDetail.java
Show resolved
Hide resolved
timja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the code as-is it works and looks good, one discussion point I think that should be looked at.
|
@jglick possible to check this please? |
Just saw this. 😀 Not a problem I think. |
2.504.1 introduced a new
DetailAPI, allowing core and plugin developers to attach details and groups to objects in Jenkins. This is currently only used byRunin core.This PR adds relevant Git info to
ScmDetailGroup, provided by scm-api-plugin.Description
For branches show:
For pull requests show:
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify