Skip to content

Conversation

@janfaracik
Copy link
Member

@janfaracik janfaracik commented Jan 17, 2025

2.504.1 introduced a new Detail API, allowing core and plugin developers to attach details and groups to objects in Jenkins. This is currently only used by Run in core.

This PR adds relevant Git info to ScmDetailGroup, provided by scm-api-plugin.

Description

For branches show:

Screenshot 2025-09-26 at 08 10 32

For pull requests show:

Screenshot 2025-09-26 at 08 11 06

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Automated tests have been added to exercise the changes
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verify that the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@janfaracik janfaracik marked this pull request as ready for review September 26, 2025 07:17
@janfaracik janfaracik requested a review from a team as a code owner September 26, 2025 07:17
@janfaracik
Copy link
Member Author

Opening for review to get thoughts.

Is the information we show the right information - e.g. is commit hash needed?

Is my usage of the API correct/are there more efficient ways of doing this.

@timja timja marked this pull request as draft September 29, 2025 12:28
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, would be nice if some of this could be centralised in e.g. git plugin or scm-api but I think its difficult because of all the special casing needed by pull requests.


I think there should be some test coverage though.

@janfaracik janfaracik marked this pull request as ready for review October 11, 2025 08:28
@janfaracik janfaracik requested a review from timja October 11, 2025 08:29
@janfaracik
Copy link
Member Author

Good for review, will need squashing.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the code as-is it works and looks good, one discussion point I think that should be looked at.

@timja
Copy link
Member

timja commented Oct 14, 2025

@jglick possible to check this please?

@jglick jglick merged commit 21c5c13 into jenkinsci:master Oct 15, 2025
17 checks passed
@jglick
Copy link
Member

jglick commented Oct 15, 2025

will need squashing

Just saw this. 😀 Not a problem I think.

@timja timja mentioned this pull request Oct 16, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants