You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@xmass Is this still valid? I see a lot of work here and want to make sure it is adequately tracked
Is there an associated Github issue with this PR? What about a Jenkins jira? If so, can you link them? If not, can you open them and note this PR?
Thank you for that.
I am coming onboard as a maintainer and link to make sure we keep as much details across the Jenkins spectrum as well.
Thanks again :-)
The goal was to use it instead of gitlabBuilds to set pending status to git defining git repository and commit parameters which the gitLabBuilds doesn't have. To modify gitLabCommitStatus was easier for me.
The problem I'm trying to adders here is when you start the pipeline the gitLabBuilds might not have the correct information about the git repository and which commit shall be used and often it confuses it with git repository of shared library. This solution I would call as workaround to missing functionality of gitlabBuilds and should be inherited by someone who understands better the code of gitLabBuilds and add the option to have possibility to set the git repository and commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure you read the instructions in the "Contribution to the Plugin" section in the README.
(if you read the above instructions, remove the paragraph and start describing the pull request)