Skip to content

honor maskValue flag for Authorization header #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

honor maskValue flag for Authorization header #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/jenkins/plugins/http_request/HttpRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,7 @@ List<HttpRequestNameValuePair> resolveHeaders(EnvVars envVars) {
for (HttpRequestNameValuePair header : customHeaders) {
String headerName = envVars.expand(header.getName());
String headerValue = envVars.expand(header.getValue());
boolean maskValue = headerName.equalsIgnoreCase(HttpHeaders.AUTHORIZATION) ||
header.getMaskValue();
boolean maskValue = header.getMaskValue();

headers.add(new HttpRequestNameValuePair(headerName, headerValue, maskValue));
}
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/jenkins/plugins/http_request/HttpRequestStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,7 @@ List<HttpRequestNameValuePair> resolveHeaders() {
for (HttpRequestNameValuePair header : customHeaders) {
String headerName = header.getName();
String headerValue = header.getValue();
boolean maskValue = headerName.equalsIgnoreCase(HttpHeaders.AUTHORIZATION) ||
header.getMaskValue();
boolean maskValue = header.getMaskValue();

headers.add(new HttpRequestNameValuePair(headerName, headerValue, maskValue));
}
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/jenkins/plugins/http_request/util/HttpRequestNameValuePair.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import java.io.Serializable;

import org.apache.http.NameValuePair;
import org.apache.http.HttpHeaders;
import org.kohsuke.stapler.DataBoundConstructor;
import org.kohsuke.stapler.QueryParameter;

Expand Down Expand Up @@ -30,7 +31,11 @@ public HttpRequestNameValuePair(String name, String value, boolean maskValue) {
}

public HttpRequestNameValuePair(String name, String value) {
this(name, value, false);
if (name.equalsIgnoreCase(HttpHeaders.AUTHORIZATION)) {
this(name, value, true);
} else {
this(name, value, false);
}
}

public String getName() {
Expand Down