fix: prevent autocomplete selection from submitting form

[Wassef-Chebbi]

Fixes #26639

Dropdown elements in the template lacked type="button", causing browsers to default them to type="submit" inside configuration forms. Clicking an autocomplete suggestion would therefore trigger an unintended form submission.
The fix sets type="button" at the template level in templates.js, covering all affected dropdowns globally — including the autocomplete and combo-box dropdowns mentioned in the issue.

Testing done

Manually tested in Firefox and Chrome by opening the Log Recorder configuration UI (/manage/log/), typing a partial value to trigger autocomplete, then selecting a suggestion via mouse click and Enter key. Verified the text field was populated and the form was not submitted. Also tested the "Build other projects" post-build action dropdown.

Screenshots (UI changes only)

Proposed changelog entries

• Prevent selecting an autocomplete suggestion submitting the configuration form

Proposed changelog category

/label bug, web-ui

Proposed upgrade guidelines

N/A

Desired reviewers

@daniel-beck @timja

[Copilot]

Pull request overview

Fixes a UI regression where selecting an autocomplete suggestion could submit the enclosing configuration form, by suppressing default submit-related event behavior during suggestion selection.

Changes:

• Add preventDefault()/stopPropagation() to autocomplete suggestion click handling.
• Treat Enter like Tab in the autocomplete item key handler.
• Modify/remove several tracked IntelliJ .idea project files (icon/name/encodings).

Reviewed changes

Copilot reviewed 1 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/main/js/components/dropdowns/autocomplete.js	Prevents autocomplete item interactions from triggering form submission.
.idea/encodings.xml	Alters tracked IntelliJ encoding configuration (unrelated to the UI regression).
.idea/icon.svg	Removes tracked IntelliJ project icon (unrelated to the UI regression).
.idea/.name	Removes tracked IntelliJ project name (unrelated to the UI regression).

Files not reviewed (2)

• .idea/.name: Language not supported
• .idea/encodings.xml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[timja]

Do we know that this is a regression? Nothing in @daniel-beck's issue suggests it is, we normally just categorise it as a bug if-so.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[timja]

Doesn't seem to work at all. PR description doesn't map to whats been committed at all

[Copilot]

Pull request overview

Copilot reviewed 1 out of 5 changed files in this pull request and generated 2 comments.

Files not reviewed (2)

• .idea/.name: Language not supported
• .idea/encodings.xml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Wassef-Chebbi]

Doesn't seem to work at all. PR description doesn't map to whats been committed at all

Sorry for the confusion, the description was outdated. The actual fix sets type="button" on all dropdown button elements in templates.js. I've updated the description to match what's been committed.

[timja]

why are you deleting these files

[Wassef-Chebbi]

Sorry about that , I've restored the .idea files to their original state. The deletion was unintentional, caused by my local IntelliJ setup. They're back now and the PR only touches templates.js.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[timja]

Seems fine, manually tested log records and "Build other projects" in freestyle builds.

Thanks!

[daniel-beck]

Do we know that this is a regression? Nothing in @daniel-beck's issue suggests it is, we normally just categorise it as a bug if-so.

Other than the regression label? 😁

#26639 (comment)

[timja]

Do we know that this is a regression? Nothing in @daniel-beck's issue suggests it is, we normally just categorise it as a bug if-so.

Other than the regression label? 😁

#26639 (comment)

I've made the regression label red now so it stands out, missed that before.

[janfaracik]

One comment - otherwise LGTM, thanks!

[Copilot]

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

[janfaracik]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[welcome]

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.