Limit job RSS changelog feed size by default by Siddhartha-singh01 · Pull Request #27088 · jenkinsci/jenkins

Siddhartha-singh01 · 2026-07-13T17:02:43Z

Job.doRssChangelog previously walked every build for a job and could produce very large feeds (hundreds of entries / hundreds of KB). That loads unnecessary build records, hurts performance, and undermines lazy loading.

This change caps the feed at 20 entries by default (as suggested in the issue). The limit can be changed with:

system property hudson.model.Job.rssChangelogMaxEntries
query parameter ?max=N

Once the limit is reached, older builds are not loaded.

Testing done

Ran the updated functional tests locally:

mvn -pl test -Dtest=RSSTest test

Result: Tests run: 26, Failures: 0, Errors: 0, Skipped: 0

New coverage in RSSTest:

default feed is limited to 20 entries (Atom and RSS 2.0)
?max= overrides the default
system property overrides the default
feeds with fewer than 20 entries are unchanged

Also compiled core/test modules successfully with:

mvn -pl core,test -am install -DskipTests -Pquick-build

Screenshots (UI changes only)

N/A (no UI change; RSS/Atom feed response size only)

Before

After

Proposed changelog entries

Limit the job RSS/Atom changelog feed size by default

Proposed changelog category

/label rfe

Proposed upgrade guidelines

N/A

Submitter checklist

The issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/core-pr-reviewers

Before the changes are marked as ready-for-merge:

Maintainer checklist

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

welcome · 2026-07-13T17:02:47Z

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

Copilot

Pull request overview

This PR improves the scalability of Job.doRssChangelog by limiting the amount of changelog history included in generated RSS/Atom feeds by default, reducing unnecessary build record loading and feed payload size.

Changes:

Add a default cap of 20 changelog entries to Job.doRssChangelog, with overrides via ?max= and a system property.
Stop iterating older builds once the requested number of changelog entries has been collected.
Add functional test coverage validating the new default and override behaviors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
core/src/main/java/hudson/model/Job.java	Introduces a default entry limit and early-exit logic when generating the RSS/Atom changelog feed.
test/src/test/java/hudson/model/RSSTest.java	Adds tests and helpers to validate default limiting and override mechanisms for `rssChangelog`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+        // Default 20 entries (JENKINS-18992). Overridable via system property or ?max=
+        int maxEntries = SystemProperties.getInteger(Job.class.getName() + ".rssChangelogMaxEntries", 20);
+        String maxParam = req.getParameter("max");
+        if (maxParam != null) {
+            try {
+                maxEntries = Math.max(1, Integer.parseInt(maxParam));


Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

        }

+        // Default 20 entries (JENKINS-18992). Overridable via system property or ?max=
+        int maxEntries = SystemProperties.getInteger(Job.class.getName() + ".rssChangelogMaxEntries", 20);


    private JenkinsRule j;

+    private static final String RSS_CHANGELOG_MAX_ENTRIES = Job.class.getName() + ".rssChangelogMaxEntries";
+
    @BeforeEach
    void setUp(JenkinsRule rule) {
        j = rule;
    }

+    @AfterEach
+    void clearRssChangelogMaxEntries() {
+        System.clearProperty(RSS_CHANGELOG_MAX_ENTRIES);
+    }


Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+        // Default 20 entries (JENKINS-18992). Overridable via system property or ?max=
+        int maxEntries = Math.max(1, SystemProperties.getInteger(Job.class.getName() + ".rssChangelogMaxEntries", 20));
+        String maxParam = req.getParameter("max");
+        if (maxParam != null) {
+            try {
+                maxEntries = Math.max(1, Integer.parseInt(maxParam));
+            } catch (NumberFormatException e) {
+                // keep default
+            }
+        }


+    void rssChangelogMaxParameter() throws Exception {
+        createJobWithChangelogEntries("rssChangelogMax", 15);
+        JenkinsRule.WebClient wc = j.createWebClient();
+        assertEquals(5, countChangelogEntries(getRssChangelogPage(wc, "rssChangelogMax", "max=5", true), true));
+        assertEquals(15, countChangelogEntries(getRssChangelogPage(wc, "rssChangelogMax", "max=50", true), true));
+    }


Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+        String maxParam = req.getParameter("max");
+        if (maxParam != null) {
+            try {
+                maxEntries = Math.min(hardLimit, Math.max(1, Integer.parseInt(maxParam)));
+            } catch (NumberFormatException e) {
+                // keep default
+            }
+        }


+        // Default 20 entries (JENKINS-18992). Overridable via system property or ?max=,
+        // but always hard-capped so callers cannot reintroduce unbounded feeds.


Siddhartha-singh01 · 2026-07-20T16:13:51Z

Hi maintainers,

This PR has been open for a bit with CI green and the Copilot feedback addressed (default limit, hard cap, property restore in tests, long parsing for oversized ?max= values, and docs for the system properties).

Would you be able to take a look when you have a moment?

cc @jenkinsci/core-pr-reviewers

Thanks!

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

core/src/main/java/hudson/model/Job.java:1163

The PR description documents only hudson.model.Job.rssChangelogMaxEntries and ?max=N, but this change also introduces a hard cap via hudson.model.Job.rssChangelogHardLimit (and enforces it for ?max=). If this is intentional, it should be called out in the PR description / release notes so administrators understand why large values for ?max= are being clamped.

        // Default 20 entries (JENKINS-18992).
        // hudson.model.Job.rssChangelogMaxEntries — default feed size (min 1)
        // hudson.model.Job.rssChangelogHardLimit — absolute ceiling (default 1000)
        // ?max=N overrides the default size but cannot exceed the hard limit.
        int hardLimit =

+    private void createJobWithChangelogEntries(String name, int n) throws Exception {
+        FreeStyleProject p = j.createFreeStyleProject(name);
+        FakeChangeLogSCM scm = new FakeChangeLogSCM();
+        p.setScm(scm);
+        for (int i = 0; i < n; i++) {
+            scm.addChange().withAuthor("u" + i);
+            j.buildAndAssertSuccess(p);
+        }
+    }


+    void rssChangelogMaxParameter() throws Exception {
+        // More than the default (20) so we prove ?max= can raise the limit, not only lower it.
+        createJobWithChangelogEntries("rssChangelogMax", 25);
+        JenkinsRule.WebClient wc = j.createWebClient();
+        assertEquals(5, countChangelogEntries(getRssChangelogPage(wc, "rssChangelogMax", "max=5", true), true));
+        assertEquals(25, countChangelogEntries(getRssChangelogPage(wc, "rssChangelogMax", "max=50", true), true));
+    }


Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

rssChangelog previously walked every build and could produce very large feeds. Cap at 20 entries by default, with overrides via system property or the max query parameter. Fixes jenkinsci#14784

Ensure the system property cannot produce an empty feed when set to 0 or a negative value. Restore the original property value after each RSSTest method instead of always clearing it.

Cap ?max= and system-property overrides with a hard limit so feeds cannot become unbounded. Strengthen tests for raising the limit above the default and for the hard cap / minimum clamps.

Name the system properties in the limit comment for operators, and parse ?max= as a long so oversized numeric values clamp to the hard limit instead of falling back to the default.

Batch FakeChangeLogSCM entries into a single build so the suite does not pay for one build per entry. Also assert Atom and RSS 2.0 for ?max=.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 13, 2026 17:02

comment-ops-bot Bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 13, 2026

Copilot started reviewing on behalf of Siddhartha-singh01 July 13, 2026 17:03 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 14, 2026 13:31

Siddhartha-singh01 force-pushed the fix/14784-limit-rss-changelog branch from bacea92 to 7f839b7 Compare July 14, 2026 13:31

Copilot started reviewing on behalf of Siddhartha-singh01 July 14, 2026 13:31 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

This was referenced Jul 14, 2026

WIP: Test parallel user scanning and more #27096

Closed

WIP: Test parallel user loading and more jenkinsci/acceptance-test-harness#2801

Closed

WIP: Test parallel user loading and more jenkinsci/bom#7075

Closed

MarkEWaite added the pct-successful This PR has successfully passed the full plugin-compatibility-test suite label Jul 15, 2026

Copilot AI review requested due to automatic review settings July 15, 2026 11:44

Copilot started reviewing on behalf of Siddhartha-singh01 July 15, 2026 11:45 View session

MarkEWaite added the ath-successful This PR has successfully passed the full acceptance-test-harness suite label Jul 15, 2026

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 15, 2026 13:02

Copilot started reviewing on behalf of Siddhartha-singh01 July 15, 2026 13:03 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 20, 2026 16:12

Siddhartha-singh01 force-pushed the fix/14784-limit-rss-changelog branch from 850d4e0 to 44f8d13 Compare July 20, 2026 16:12

Copilot started reviewing on behalf of Siddhartha-singh01 July 20, 2026 16:12 View session

Copilot AI reviewed Jul 20, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 20, 2026 16:27

Copilot AI reviewed Jul 20, 2026

Siddhartha-singh01 added 3 commits July 27, 2026 19:24

Limit job RSS changelog feed size by default

0a55940

rssChangelog previously walked every build and could produce very large feeds. Cap at 20 entries by default, with overrides via system property or the max query parameter. Fixes jenkinsci#14784

Clamp rssChangelogMaxEntries and restore system property in tests

a46b41c

Ensure the system property cannot produce an empty feed when set to 0 or a negative value. Restore the original property value after each RSSTest method instead of always clearing it.

Harden rssChangelog limits and cover max overrides

0d3a814

Cap ?max= and system-property overrides with a hard limit so feeds cannot become unbounded. Strengthen tests for raising the limit above the default and for the hard cap / minimum clamps.

Siddhartha-singh01 added 2 commits July 27, 2026 19:24

Document rssChangelog properties and parse max as long

6f8e13f

Name the system properties in the limit comment for operators, and parse ?max= as a long so oversized numeric values clamp to the hard limit instead of falling back to the default.

Speed up rssChangelog tests and cover RSS 2.0 max overrides

30315ee

Batch FakeChangeLogSCM entries into a single build so the suite does not pay for one build per entry. Also assert Atom and RSS 2.0 for ?max=.

Copilot AI review requested due to automatic review settings July 27, 2026 13:54

Siddhartha-singh01 force-pushed the fix/14784-limit-rss-changelog branch from cdf0a33 to 30315ee Compare July 27, 2026 13:54

Copilot AI reviewed Jul 27, 2026

This was referenced Aug 4, 2026

[WIP] Test several pull requests #27190

Closed

[WIP] Test several pull requests jenkinsci/bom#7189

Draft

[WIP] Test several pull requests #27191

Closed

[WIP] Test several pull requests #27206

Closed

Navigation Menu

Uh oh!

Uh oh!

Limit job RSS changelog feed size by default - #27088

Limit job RSS changelog feed size by default#27088
Siddhartha-singh01 wants to merge 5 commits into
jenkinsci:masterfrom
Siddhartha-singh01:fix/14784-limit-rss-changelog

Siddhartha-singh01 commented Jul 13, 2026

Uh oh!

welcome Bot commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Siddhartha-singh01 commented Jul 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// Default 20 entries (JENKINS-18992). Overridable via system property or ?max=,
		// but always hard-capped so callers cannot reintroduce unbounded feeds.

Uh oh!

Uh oh!

Conversation

Siddhartha-singh01 commented Jul 13, 2026

Testing done

Screenshots (UI changes only)

Before

After

Proposed changelog entries

Proposed changelog category

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

Uh oh!

welcome Bot commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Siddhartha-singh01 commented Jul 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants