Fix min/max form validation message to reflect inclusive boundary - #27141
Open
thswlsqls wants to merge 4 commits into
Open
Fix min/max form validation message to reflect inclusive boundary#27141thswlsqls wants to merge 4 commits into
thswlsqls wants to merge 4 commits into
Conversation
MarkEWaite
requested changes
Jul 28, 2026
MarkEWaite
left a comment
Contributor
There was a problem hiding this comment.
Causes test failures. Failing tests need to be fixed before the change is reviewed.
The min/max validation messages in hudson-behavior.js now say "larger than or equal to" and "less than or equal to", but NumberTest still expected the old wording, breaking minValidation, maxValidation and minAndMaxValidation.
Contributor
Author
|
@MarkEWaite Thanks for the review. You're right — |
Contributor
Author
|
@MarkEWaite CI is now green on the latest build — all four test jobs (JDK 21, JDK 25, Windows, and ATH) pass, so the test failures you flagged are resolved. Whenever you have time, could you take another look? No rush. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27140
The number-field client validator
registerMinMaxValidator()accepts the boundary values but its min-only and max-only error messages describe an exclusive range, misleading users about what is actually allowed.Testing done
No JavaScript unit-test framework exists in the tree, so there is no automated test.
min=5,value=5is accepted while the oldvalue=4message read "should be larger than 5", implying 5 is invalid; the max-only branch (line 879) behaves the same. After the change the messages read "larger than or equal to" / "less than or equal to", matching the accepted range and the sibling min+max branch ("should be between …", line 843).yarn eslintandyarn prettier --checkon the file pass.Screenshots (UI changes only)
Text-only change to an existing client-side validation message; no layout change.
min):This value should be larger than NThis value should be larger than or equal to NThe max-only branch changes analogously (
less than→less than or equal to).Proposed changelog entries
Proposed changelog category
/label bug, web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.