Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Bootstrap 5 theme support #39

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

alex-tw-lam
Copy link
Contributor

Description

This PR integrates Bootstrap version 5.3.3 into the JSON Editor Parameter plugin. The changes include:

  • pom.xml:
    • Added a new dependency for Bootstrap.
    • Configured an artifact item to include the minified Bootstrap CSS (bootstrap.min.css), with file mappers to flatten and rename the file.
  • index.jelly:
    • Updated to include the Bootstrap adjunct so that the minified CSS is loaded with the page.

These modifications ensure that the Bootstrap styles are available and correctly applied in the plugin’s UI.

Testing done

  • Build Verification: Successfully built the project using Maven, confirming that the Bootstrap dependency and file mapping are correctly processed.
  • Manual Testing: Deployed the plugin in a test Jenkins instance and verified that the bootstrap.min.css file is correctly included and applied. The UI rendered as expected with the new styling changes.
  • Regression Check: Performed a basic regression test to ensure no other functionality was affected by these changes.

Submitter checklist

  • Made sure to open from a topic/feature/bugfix branch.
  • Ensured that the pull request title represents the desired changelog entry.
  • Described the changes made and their purpose.
  • Linked to relevant issues in GitHub or Jira (if applicable).
  • Linked to any relevant pull requests, especially upstream and downstream changes.
  • Confirmed that tests have been provided or manual testing was performed to demonstrate the feature works or the issue is fixed.

@alex-tw-lam alex-tw-lam requested a review from a team as a code owner March 19, 2025 15:14
@alex-tw-lam
Copy link
Contributor Author

Addresses #9

@chonton chonton merged commit 9bb29ba into jenkinsci:main Mar 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants