Add a backward compatible way of getting random bytes #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails because of |
|
crypto.rand_bytes is deprecated in erlang/OTP 20. I believe that this PR fixes the error by using strong_rand_bytes. @jonalmeida have you been able to publish a module up that would fix this, or waiting for merge here? |
|
@sb8244 Waiting for merge and/or someone to fix the CI build since it's not related to this. |
|
Thanks for the update @jonalmeida. I'm still seeing some issues with the code that I'm trying to get working, although it could be related to that library and not this one. I actually see that websocket_client master has the strong_rand_bytes which is what I needed (not backwards compat) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should allow you to keep using an older version of OTP with
rand_bytes/1otherwise usesstrong_rand_bytes/1