Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behaviour when use docker or sail #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suleymanozev
Copy link

Solves #14

@jessarcher
Copy link
Owner

jessarcher commented Jul 19, 2022

Thanks!

From reading the code and testing it, it looks like there is some inconsistency between Sail and regular Docker Compose.

If Sail is detected, it will always try to run it in the Sail container, even if it's not running (existing behaviour).

Otherwise, if Docker Compose is detected, it will only run the command inside the container if the container is running (new behaviour).

I think it would be good to keep these consistent.

Additionally, I'm wondering whether it's worth spitting out a warning if it runs the command outside of the container when Sail or Docker Compose are detected but not running?

@amrography
Copy link

amrography commented Feb 22, 2024

@jessarcher Can we have a flag like DISABLE_ARTISAN_SAIL ?

here:

if [ "$docker_compose_config_path" = '' || $DISABLE_ARTISAN_SAIL ]; then

and usage

DISABLE_ARTISAN_SAIL=true artisan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants