Add failing element to satisfyAll and satisfyAny error messages
#482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #482 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 582 584 +2
Branches 148 150 +2
=========================================
+ Hits 582 584 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
keeganwitt
reviewed
Aug 7, 2022
| @@ -1,23 +1,28 @@ | |||
| export function toSatisfyAny(actual, expected) { | |||
| const { printReceived, printExpected, matcherHint } = this.utils; | |||
|
|
|||
| const pass = actual.some(expected); | |||
| const failingElement = pass ? actual.find(expected) : actual.find(a => !expected(a)); | |||
There was a problem hiding this comment.
Why return the first non-matching element? In the case of toSatisfyAny, all elements would fail the predicate during failure scenarios.
keeganwitt
reviewed
Aug 7, 2022
| @@ -1,23 +1,28 @@ | |||
| export function toSatisfyAll(actual, expected) { | |||
| const { printReceived, printExpected, matcherHint } = this.utils; | |||
|
|
|||
| const pass = actual.every(expected); | |||
| const failingElement = pass ? actual.find(expected) : actual.find(a => !expected(a)); | |||
There was a problem hiding this comment.
There could be multiple failing elements, right? I'm wondering if it'd be better to print them all instead of just the first one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add failing element to
satisfyAllandsatisfyAnyerror messagesWhy
This will give a clearer error message of why the assertion failed
Notes
Housekeeping