Ensure record type metadata is initialized correctly

libs/connected/connected-ui/src/lib/useListMetadata.tsx

@@ -96,6 +96,7 @@ async function fetchListMetadata(
         });
       }
     } catch (ex) {
+      // IsPersonType is only available in orgs where this feature is enabled - so if it fails we don't need to monkey-patch
       logger.error('Error monkey-patching PersonAccount record types', ex);
     }
   }

libs/features/record-type-manager/src/lib/utils/record-types.utils.ts

@@ -1,13 +1,12 @@
-import { logger } from '@jetstream/shared/client-logger';
 import { xmlUtils } from '@jetstream/shared/ui-utils';
+import { ensureArray } from '@jetstream/shared/utils';
 import {
   ListItem,
   ListMetadataResult,
   ReadMetadataRecordType,
   ReadMetadataRecordTypeExtended,
   ReadMetadataRecordTypePicklistEntryExtended,
 } from '@jetstream/types';
-import { Query, composeQuery, getField } from '@jetstreamapp/soql-parser-js';
 import JSZip from 'jszip';
 import groupBy from 'lodash/groupBy';
 import { RecordTypePicklistSummary } from '../types/record-types.types';
@@ -17,14 +16,16 @@ const XML_NS = xmlUtils.SOAP_XML_NAMESPACE;
 /**
  * Some fullName have invalid objects vs reality
  * Some picklist field names are different from metadadata API vs reality
+ * Ensure array data types are consistent
  * @param record
  * @returns
  */
 export function repairAndEnrichMetadata(record: ReadMetadataRecordType): ReadMetadataRecordTypeExtended {
   const [sobject, recordType] = getValidSobjectNameFromFullName(record.fullName);
-  const picklistValues = record.picklistValues.map((picklistValues): ReadMetadataRecordTypePicklistEntryExtended => {
+  const picklistValues = ensureArray(record.picklistValues).map((picklistValues): ReadMetadataRecordTypePicklistEntryExtended => {
     const fieldName = getValidFieldNameName(decodeURIComponent(picklistValues.picklist));
 
+    picklistValues.values = ensureArray(picklistValues.values);
     picklistValues.values.forEach((value) => {
       value.fullName = decodeURIComponent(value.fullName);
     });
@@ -94,73 +95,6 @@ function setOriginalMetadataSobjectName(modifiedValues: RecordTypePicklistSummar
   });
 }
 
-export function getRecordTypeSoql(): string {
-  const query: Query = {
-    fields: [
-      getField('Id'),
-      getField('Name'),
-      getField('Description'),
-      getField('DeveloperName'),
-      getField('IsActive'),
-      getField('IsPersonType'),
-      getField('NamespacePrefix'),
-      getField('SobjectType'),
-    ],
-    sObject: 'RecordType',
-    orderBy: [
-      {
-        field: 'SobjectType',
-        order: 'ASC',
-      },
-      {
-        field: 'Name',
-        order: 'ASC',
-      },
-    ],
-  };
-
-  const soql = composeQuery(query);
-  logger.log('getRecordTypeQuery()', soql);
-  return soql;
-}
-
-export function getRecordTypeMetadataSoql(id: string): string {
-  const query: Query = {
-    fields: [
-      getField('Id'),
-      getField('Name'),
-      getField('FullName'),
-      getField('IsPersonType'),
-      getField('Metadata'),
-      getField('SobjectType'),
-    ],
-    sObject: 'RecordType',
-    where: {
-      left: {
-        field: 'Id',
-        operator: '=',
-        value: id,
-        literalType: 'STRING',
-      },
-    },
-    limit: 1,
-    orderBy: [
-      {
-        field: 'SobjectType',
-        order: 'ASC',
-      },
-      {
-        field: 'Name',
-        order: 'ASC',
-      },
-    ],
-  };
-
-  const soql = composeQuery(query);
-  logger.log('getRecordTypeMetadata()', soql);
-  return soql;
-}
-
 function getRecordTypeModifiedData(
   recordType: ReadMetadataRecordTypeExtended,
   modifiedValues: RecordTypePicklistSummary[]

libs/types/src/lib/salesforce/record.types.ts

@@ -439,7 +439,6 @@ export interface RecordTypeRecord {
   Description: string | null;
   DeveloperName: string;
   IsActive: boolean;
-  IsPersonType: boolean;
   NamespacePrefix: string | null;
   SobjectType: string;
 }
@@ -449,7 +448,6 @@ export interface RecordTypeMetadataRecord {
   Id: string;
   Name: string;
   FullName: string;
-  IsPersonType: boolean;
   Metadata: RecordTypeMetadataTooling;
   SobjectType: string;
 }