Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow deploying metadata from comparison modal #1227

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

paustint
Copy link
Contributor

After comparison, allow deploying metadata to a target org to make it easier to only deploy modified metadata instead having to track it separately from the main page

resolves #1150

After comparison, allow deploying metadata to a target org to make it easier to only deploy modified metadata instead having to track it separately from the main page

resolves #1150
@paustint paustint requested a review from Copilot March 26, 2025 03:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the ability to deploy metadata directly from the comparison modal by introducing a new deploy confirmation modal and updating related components and utils.

  • Introduces a new DeployComparedMetadataModal for handling deployment from metadata comparisons
  • Updates metadata utils to extract deployable metadata from the comparison tree
  • Enhances the modal footer with an added deploy button and tooltips

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libs/features/deploy/src/view-or-compare-metadata/DeployComparedMetadataModal.tsx New modal component for configuring and initiating metadata deployment
libs/features/deploy/src/view-or-compare-metadata/viewOrCompareMetadataTypes.ts Adds type definitions for deploy metadata items
libs/features/deploy/src/view-or-compare-metadata/ViewOrCompareMetadataModalFooter.tsx Integrates a deploy button with additional tooltip guidance
libs/features/deploy/src/view-or-compare-metadata/viewOrCompareMetadataUtils.tsx Adds utility to extract deployable metadata from the comparison tree
libs/features/deploy/src/view-or-compare-metadata/ViewOrCompareMetadataModal.tsx Integrates the deploy modal into the main metadata view/comparison flow
libs/ui/src/lib/form/checkbox/Checkbox.tsx Updates checkbox label type to support richer content
libs/features/deploy/src/utils/DeployMetadataStatusModal.tsx Minor UI adjustment by replacing a div with a Grid for footer layout
libs/features/deploy/src/deploy-to-different-org/DeployMetadataToOrgConfigModal.tsx Introduces a lock prop to disable destination org selection during deployment
Files not reviewed (1)
  • apps/docs/docs/deploy/deploy-metadata.mdx: Language not supported
Comments suppressed due to low confidence (2)

libs/features/deploy/src/view-or-compare-metadata/ViewOrCompareMetadataModal.tsx:212

  • The variable 'files' is used in getDeployMetadataFromComparisonTree but isn't defined in the component scope. Please ensure that 'files' is properly declared or obtained (e.g. via a hook or prop) before use.
setDeployConfirmationModalConfig({ open: true, targetOrg, items: getDeployMetadataFromComparisonTree(files) });

libs/features/deploy/src/view-or-compare-metadata/DeployComparedMetadataModal.tsx:26

  • [nitpick] The state variable for selected items is named 'selectedItems' while its setter is called 'setSelectedFiles'. Consider renaming one of them (e.g. to 'setSelectedItems') for naming consistency.
const [selectedItems, setSelectedFiles] = useState<Set<string>>( ... )

@paustint paustint merged commit eda6043 into main Mar 26, 2025
7 checks passed
@paustint paustint deleted the feat/1150 branch March 30, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy only changed metadata
1 participant