Skip to content

Comments

Bug/bug bash 20251204#1460

Merged
paustint merged 10 commits intomainfrom
bug/bug-bash-20251204
Dec 5, 2025
Merged

Bug/bug bash 20251204#1460
paustint merged 10 commits intomainfrom
bug/bug-bash-20251204

Conversation

@paustint
Copy link
Contributor

@paustint paustint commented Dec 4, 2025

This pull request focuses on improving clarity and consistency in terminology across the codebase and documentation, specifically replacing "non-managed" with "unmanaged" when referring to tests and fields. It also includes a minor Salesforce API version bump and some code cleanup by removing unnecessary ESLint comments. Additionally, error handling for uncaught exceptions has been refactored for improved logging.

Terminology updates:

  • Updated all references of "non-managed" tests and fields to "unmanaged" in documentation, UI labels, and deployment options to ensure consistency and clarity for users. [1] [2] [3] [4]

Error handling improvements:

  • Refactored uncaught error handling in response.handlers.ts to improve logging: removed redundant Rollbar logging and enhanced reporting of exceptions that occur within the error handler itself. [1] [2]

Salesforce API version update:

  • Increased SFDC_API_VERSION from "64.0" to "65.0" in CI workflow configuration for compatibility with the latest Salesforce features. (.github/workflows/ci.yml)

Code cleanup:

Deployment UI improvements:

  • Improved deployment options UI by adding error messaging when invalid test level options are selected for production orgs, and refactored related component structure for better maintainability. [1] [2] [3] [4]

There are a ton of places where SFDC returns an error and we don't need to log these to rollbar as they rarely would indicate an actual bug.
The issue couldn't be reproduced, but if idMap[selectedItem] didn't return an item then the application would crash
If an org is modified on the deployment selection page, after continuing the application would be in an infinite loading state.
Comments in a package manifest caused XML parsing to fail
Change non-managed to unmanaged
Copilot AI review requested due to automatic review settings December 4, 2025 16:50
@socket-security
Copy link

socket-security bot commented Dec 4, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedxlsx@​0.20.3100100100100100

View full report

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on improving consistency and clarity across the codebase through terminology updates, a Salesforce API version bump, code cleanup, and enhanced error handling.

Key Changes:

  • Updated all references from "non-managed" to "unmanaged" for tests and fields across documentation and UI
  • Bumped Salesforce API version from v64.0 to v65.0 throughout the codebase
  • Enhanced Tree component with stable callback references using useRef pattern and improved null safety

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libs/ui/src/lib/tree/Tree.tsx Added useRef pattern for onSelected callback stability, made onSelected required, added null checks for item lookups
libs/test-utils/src/lib/sfdc-fields.data-factory.ts Updated Salesforce API version references in mock data from v64.0 to v65.0
libs/shared/utils/src/lib/utils.ts Updated default API version from v64.0 to v65.0
libs/shared/utils/src/lib/__tests__/utils.spec.ts Updated expected test output to reflect v65.0 API version
libs/salesforce-api/src/lib/salesforce-package.utils.ts Enhanced XML builder configuration to ignore comments during parsing
libs/features/update-records/src/selection/MassUpdateRecordsSelection.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/sobject-export/src/SObjectExport.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/salesforce-api/src/SalesforceApi.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/query/src/QueryOptions/accordion-titles/*.tsx Removed unnecessary ESLint disable comments from multiple query accordion components
libs/features/query/src/QueryOptions/QueryLimit.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/query/src/QueryOptions/IncludeDeletedRecords.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/manage-permissions/src/*.tsx Removed unnecessary ESLint disable comments from permission management components
libs/features/load-records/src/steps/*.tsx Removed unnecessary ESLint disable comments from load records automation components
libs/features/formula-evaluator/src/FormulaEvaluator.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/deploy/src/utils/DeployMetadataOptions.tsx Updated terminology to "unmanaged" tests, added validation for NoTestRun option in production orgs
libs/features/deploy/src/selection-components/MetadataSelection.tsx Optimized useEffect dependency to only watch selectedOrg.uniqueId instead of entire object
libs/features/deploy/src/DeployMetadataSelection.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/deploy/src/DeployMetadataDeployment.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/debug-log-viewer/src/DebugLogViewer.tsx Removed unnecessary ESLint disable comment for empty interface
libs/features/create-object-and-fields/src/*.tsx Removed unnecessary ESLint disable comments from create fields components
libs/features/anon-apex/src/AnonymousApex.tsx Removed unnecessary ESLint disable comment for empty interface
apps/docs/docs/query/query.mdx Updated documentation terminology from "Non-Managed" to "Unmanaged" fields
apps/docs/docs/deploy/deploy-metadata.mdx Updated documentation terminology from "non-managed" to "unmanaged" tests
apps/api/src/app/utils/response.handlers.ts Refactored error handler to move Rollbar logging to catch block and improve exception reporting
.github/workflows/ci.yml Updated SFDC_API_VERSION environment variable from 64.0 to 65.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@paustint paustint merged commit 7d23663 into main Dec 5, 2025
10 checks passed
@paustint paustint deleted the bug/bug-bash-20251204 branch December 5, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant