Skip to content

Conversation

@afarber
Copy link
Contributor

@afarber afarber commented Dec 15, 2025

Fixes #13647

  • Add ContainerLifeCycleMap<K, V extends LifeCycle> that implements Map while managing values as beans
  • Values are automatically started/stopped with the container lifecycle
  • Removal through keySet(), values(), entrySet() views also unregisters beans
  • Add missing tests for AttributeContainerMap
  • Update bean.adoc with documentation for both classes

@joakime joakime moved this to 👀 In review in Jetty 12.1.6 Dec 15, 2025
@joakime joakime requested a review from gregw December 17, 2025 21:30
@sbordet sbordet removed this from Jetty 12.1.6 Jan 5, 2026
@sbordet sbordet moved this to 👀 In review in Jetty 12.1.7 Jan 5, 2026
@sbordet
Copy link
Contributor

sbordet commented Jan 5, 2026

@gregw I'm not against it, but I would like to understand where this is necessary, and update the relevant code to use this new class, otherwise it will be an unused class in the source tree.

@afarber afarber force-pushed the 13647-container-life-cycle-map branch from 7f24e3c to 8436ee3 Compare January 10, 2026 10:08
@afarber afarber force-pushed the 13647-container-life-cycle-map branch from 8436ee3 to 1aa16a5 Compare January 17, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

ContainerLifeCycleMap

3 participants