Skip to content

Issue #14209 - Allow custom XmlParser in Descriptor handling #14210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joakime wants to merge 12 commits into
base: jetty-12.1.x
Choose a base branch
from
Open

Issue #14209 - Allow custom XmlParser in Descriptor handling #14210

joakime wants to merge 12 commits into from

Conversation

@joakime
Copy link
Contributor

@joakime joakime commented Dec 18, 2025

Reworking WebDescriptor and MetaData to allow for custom XmlParser usage.

@joakime joakime requested a review from janbartel December 18, 2025 17:29
@joakime joakime self-assigned this Dec 18, 2025
@joakime joakime added Enhancement Sponsored This issue affects a user with a commercial support agreement labels Dec 18, 2025
@joakime joakime moved this to 👀 In review in Jetty 12.1.6 Dec 18, 2025
@joakime joakime linked an issue Dec 18, 2025 that may be closed by this pull request
Unable to use custom XmlParser for WebAppContext / MetaData descriptor parsing #14209
Open
@joakime joakime requested review from janbartel and lorban December 19, 2025 15:53
@joakime
Copy link
Contributor Author

joakime commented Dec 19, 2025

I haven't done the ee10/ee11 version yet, as I want to get an OK on this approach first.

janbartel
janbartel previously requested changes Dec 19, 2025
View reviewed changes
jetty-ee9/jetty-ee9-webapp/src/main/java/org/eclipse/jetty/ee9/webapp/MetaData.java Outdated
public void setValidateXml(boolean validateXml)
{
_validateXml = validateXml;
if (_xmlParser != null)
Copy link
Contributor

@janbartel janbartel Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this class always instantiates an instance of XmlParser, so it will never be null, so you can never get a validating parser by calling setValidateXml(true).

sbordet
sbordet requested changes Jan 9, 2026
View reviewed changes
@joakime joakime requested a review from sbordet January 12, 2026 18:42
sbordet
sbordet requested changes Jan 13, 2026
View reviewed changes
@joakime joakime marked this pull request as ready for review January 13, 2026 16:31
@joakime joakime changed the title Issue #14209 - Initial proposal using ee9 for custom XmlParser in Descriptor handling Issue #14209 - Allow custom XmlParser in Descriptor handling Jan 13, 2026
@joakime
Small tweak to new WebAppContextTest.testCustomXmlParser to allow ee8…
e76cd06 
… environment to work.

* The `ee8` environment has a bug that needs to be fixed.
  See jetty/jetty-toolchain#331
@joakime joakime requested a review from sbordet January 14, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janbartel janbartel janbartel left review comments

@lorban lorban Awaiting requested review from lorban

@sbordet sbordet Awaiting requested review from sbordet

Requested changes must be addressed to merge this pull request.

Assignees

@joakime joakime

Labels

Enhancement Sponsored This issue affects a user with a commercial support agreement

Projects

Jetty 12.1.6
Status: 👀 In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to use custom XmlParser for WebAppContext / MetaData descriptor parsing

5 participants

@joakime @janbartel @sbordet @lorban