Issue #12660 - support tagging in WebSocket ClientUpgradeRequest #14259
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
sbordet
requested changes
Dec 29, 2025
Contributor
sbordet
left a comment
sbordet
left a comment
There was a problem hiding this comment.
Looks good on core, but should you not do the same change in the eeN versions of ClientUpgradeRequest?
Contributor
Author
|
@sbordet we don't have specific EE versions of the Jetty client for EE10+, only websocket-core and jetty-core APIs. We do for EE9/EE8, although I don't think it is necessary to add this to EE9/EE8. |
sbordet
approved these changes
Jan 5, 2026
lachlan-roberts
deleted the
fix/jetty-12.1.x/12660-ClientUpgradeRequest-tagging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12660
Expose the
tag()andgetTag()methods which are available on theorg.eclipse.jetty.client.Requestalso onClientUpgradeRequestandCoreClientUpgradeRequestso they can be used for WebSocket Upgrades.