catch validation errors during patch serialization #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiptoomm
commented
Feb 6, 2018
kiptoomm
commented
- Adds a block to catch validation exceptions that occur when PATCHing a resource
houndci-bot
reviewed
Feb 6, 2018
| """Immediately raises a :exc:`DeserializationException`.""" | ||
| raise DeserializationException | ||
|
|
||
| class raise_s_validation_error(DefaultSerializer): |
- we want to force triggering of validation exceptions during serialiation - add unit test to verify that validation exception is raised on patch - a validation exception should be raised when a validation error occurs during serialization - create a serializer class that automatically throws the validation exception - uses marshmallow's ValidationError exception, but in theory any exception could be used to force the check in order to pass them through to the flask-restless validations exceptions handler and thus have it return meaningful errors to client fix spacing issue caught by houndci
kiptoomm
force-pushed
the
debug_validate_patch
branch
from
287b085 to
b3788d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.