Migrate life cycle commands from jfrog-cli to jfrog-cli-artifactory #1351
+48
−1,486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bhanurp
commented
Feb 18, 2025
•
bhanurp
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Moved some common functions used across commands from cli to cli-core
This was referenced Feb 18, 2025
RobiNino
requested changes
Feb 19, 2025
plugins/components/commandcomp.go
Outdated
| @@ -183,6 +206,18 @@ func WithBoolDefaultValueFalse() BoolFlagOption { | |||
| } | |||
| } | |||
|
|
|||
| func WithHiddenTrue() StringFlagOption { | |||
There was a problem hiding this comment.
A similar func already exists - SetHiddenStrFlag
plugins/common/utils.go
Outdated
| return os.Getenv(envKey) | ||
| } | ||
|
|
||
| func CreateDownloadConfiguration(c *components.Context) (downloadConfiguration *artifactoryUtils.DownloadConfiguration, err error) { |
There was a problem hiding this comment.
Some of these aren't really plugins utils, I suggest placing them in jfrog-cli-artifactory.
In addition, since they duplicate existing functions in jfrog-cli (only differ in context), let's try to make a common function out of them or somehow overcome the context difference
There was a problem hiding this comment.
Agree moved lifecycle functions to jfrog-cli-artifactory
RobiNino
requested changes
Mar 17, 2025
RobiNino
approved these changes
Mar 20, 2025
bhanurp
added
ignore for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.