Fix parsing Docker scan flags and Args

[attiasas]

• All tests have passed. If this feature is not already covered by the tests, new tests have been added.
• The pull request is targeting the master branch.
• The code has been validated to compile successfully by running go vet ./....
• The code has been formatted properly using go fmt ./....

---

Depends on:

• Convert flags public jfrog-cli-core#1507

Note: There is still an issue parsing flags/arguments.
This PR only fixing that the inner docker scan cmd flags will be parsed as flags and not arguments.
For the scan to work you need to run: docker scan <img> [flags] (argements before flags)

[RemiBou]

no test ?

[attiasas]

added

[RemiBou]

why not use flagNames in the whole method and then convert it to slice ?

[attiasas]

if we do it, when converting to slice you will need to go over the 2 sources of flags to locate where it is.
flagNames used only so we can validate quick if a flag already exist. I can switch it to just check if the slice contains the value and remove flagNames from the func... IMO its ok like this

[github-actions]

---

🐸 JFrog Frogbot

[ehl-jf]

@attiasas What about creating a new function like https://github.com/jfrog/jfrog-cli/blob/master/buildtools/cli.go#L1131 for example extractDockerScanOptionsFromArgs and adding additional options to securityCLI.DockerScan to provide the security's specific options ?

[attiasas]

will be implemented at:

• JGC-434 - Look for undeclared flags in arguments jfrog-cli-core#1511