Skip to content

Introducing schema changes in Config Profile #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Feb 25, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR introduces new schema to config profile in order to support new capabilities and future plans:

ConfigProfile: added several new fields
IsBasicProfile
GeneralConfig (struct)

GeneralConfig: new fields and fields from other structs moved into it
ReleasesRepo (moved from Module)
AnalyzerManagerVersion (moved from Module)
ReportAnalytics (moved from Module)
ExcludePatterns
ResultsOutputDir
AllowPartialResults

FrogbotConfig: added new fields
AvoidExtraMessages
AddSuccessComment
SkipAutoFix
IncludeAllRepositoryVulnerabilities

Module: deleted, renamed and added fields
DepsRepo (Added)
ReleasesRepo (deleted)
AnalyzerManagerVersion (deleted)
AdditionalPathsForModule (deleted)
ExcludePaths (renamed to ExcludePatterns)
ProtectedBranches (deleted)
IncludeExcludeMode (deleted)
IncludeExcludePattern (deleted)
ReportAnalytics (deleted)

ScanConfig:
ScanTimeout (deleted)
ExcludePattern (deleted)
EnableScaScan (moved to ScaScannerConfig)
EnableContextualAnalysisScan (moved to ContextualAnalysisScannerConfig)
ApplicationsScannerConfig (deleted)
ServicesScannerConfig (deleted)
ScaScannerConfig (added)
ContextualAnalysisScannerConfig (added)

ScaScannerConfig contains all configurable Sca options
CaScannerConfig was added ExcludePatterns
SastScannerConfig, SecretsScannerConfig and IacScannerConfig were added with IncludePatterns

@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes labels Feb 25, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 25, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 9, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 9, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 10, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 10, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you can add a description of the schema changes it will help

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 1, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 1, 2025
Copy link
Contributor

github-actions bot commented Apr 1, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


@eranturgeman eranturgeman merged commit 14e8fd1 into jfrog:dev Apr 2, 2025
24 checks passed
EyalDelarea pushed a commit to EyalDelarea/jfrog-client-go that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants