-
Notifications
You must be signed in to change notification settings - Fork 158
Introducing schema changes in Config Profile #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eranturgeman
merged 10 commits into
jfrog:dev
from
eranturgeman:integrating-new-cc-schema-changes
Apr 2, 2025
Merged
Introducing schema changes in Config Profile #1090
eranturgeman
merged 10 commits into
jfrog:dev
from
eranturgeman:integrating-new-cc-schema-changes
Apr 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegrating-new-cc-schema-changes
…ntegrating-new-cc-schema-changes
…ntegrating-new-cc-schema-changes
7 tasks
attiasas
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if you can add a description of the schema changes it will help
…ntegrating-new-cc-schema-changes
…anges' into integrating-new-cc-schema-changes
EyalDelarea
pushed a commit
to EyalDelarea/jfrog-client-go
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new schema to config profile in order to support new capabilities and future plans:
ConfigProfile: added several new fields
IsBasicProfile
GeneralConfig (struct)
GeneralConfig: new fields and fields from other structs moved into it
ReleasesRepo (moved from Module)
AnalyzerManagerVersion (moved from Module)
ReportAnalytics (moved from Module)
ExcludePatterns
ResultsOutputDir
AllowPartialResults
FrogbotConfig: added new fields
AvoidExtraMessages
AddSuccessComment
SkipAutoFix
IncludeAllRepositoryVulnerabilities
Module: deleted, renamed and added fields
DepsRepo (Added)
ReleasesRepo (deleted)
AnalyzerManagerVersion (deleted)
AdditionalPathsForModule (deleted)
ExcludePaths (renamed to ExcludePatterns)
ProtectedBranches (deleted)
IncludeExcludeMode (deleted)
IncludeExcludePattern (deleted)
ReportAnalytics (deleted)
ScanConfig:
ScanTimeout (deleted)
ExcludePattern (deleted)
EnableScaScan (moved to ScaScannerConfig)
EnableContextualAnalysisScan (moved to ContextualAnalysisScannerConfig)
ApplicationsScannerConfig (deleted)
ServicesScannerConfig (deleted)
ScaScannerConfig (added)
ContextualAnalysisScannerConfig (added)
ScaScannerConfig contains all configurable Sca options
CaScannerConfig was added ExcludePatterns
SastScannerConfig, SecretsScannerConfig and IacScannerConfig were added with IncludePatterns