make javadoc work with java8 #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently ther are two problems. first is with diffplus spotless, which fails the formatting when using java8: diffplug/spotless#658 second, javadoc fails when using java9 and newer when not setting JAVA_HOME like on many linux distros, and macos: apache/maven-javadoc-plugin@4bf64b02 this will be only fixed with the maven-javadoc-plugin- 3.2.1 whenever it will be released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently ther are two problems. first is with diffplus spotless,
which fails the formatting when using java8:
diffplug/spotless#658
second, javadoc fails when using java9 and newer when not setting
JAVA_HOME like on many linux distros, and macos:
apache/maven-javadoc-plugin@4bf64b02
this will be only fixed with the maven-javadoc-plugin- 3.2.1
whenever it will be released.
Thank you so much to take time to contribute to the project.
Before submitting the pull-request please ensure that you have first:
mvn -Prun-its clean install