Allow setting font path and font color by frequency #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naslundx
force-pushed
the
font-path-and-color
branch
from
bd6e5d4 to
15bd3e8
Compare
jimbarrett27
approved these changes
Aug 18, 2024
examples/sherlock.py
Outdated
| @@ -1,3 +1,4 @@ | |||
| import math | |||
There was a problem hiding this comment.
where do we use math? (the stdlib, not the concept)
| size: int = 1 | ||
| color: tuple[int, int, int] = (255, 255, 0) | ||
|
|
||
| def color(self, frequency: float) -> Color: |
There was a problem hiding this comment.
(not actually bothered about it)
There was a problem hiding this comment.
First counterclockwise, now this :(
|
So weird, I'm getting |
naslundx
force-pushed
the
font-path-and-color
branch
2 times, most recently
from
b1b3951 to
06285e8
Compare
naslundx
force-pushed
the
font-path-and-color
branch
from
06285e8 to
0149bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Fixes #23
Also added 'Color' as a type alias for tuple[int, int, int]