Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new workflow for publishing #29

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Conversation

jimbarrett27
Copy link
Owner

not sure how to properly test this...

@jimbarrett27 jimbarrett27 requested a review from naslundx August 20, 2024 14:44
@naslundx
Copy link
Collaborator

Nice to see! 🎉 I wonder about the duplication in the publish script. Either...

  1. We block all direct pushes to main (everything goes through a PR), that should mean that every piece of code has been tested - merging from dev to main should also be a PR. In that case we only "need" the publishing part in the publish workflow.

  2. We reuse the PR workflow and run the job before the publish (if it succeeded). That's possible AFAIK: https://docs.github.com/en/actions/sharing-automations/reusing-workflows

@jimbarrett27
Copy link
Owner Author

Yeah, I was wondering the same, wasn't sure what the best practice was.

It would also be nice to block merges to main if the version hasn't been bumped, didn't find a good way to do that yet either

@naslundx
Copy link
Collaborator

It would also be nice to block merges to main if the version hasn't been bumped, didn't find a good way to do that yet either

Oh that's a good one. Worth creating an issue for, I can investigate it later.

@jimbarrett27 jimbarrett27 marked this pull request as draft August 22, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants