feat: adding ability to run for orgs/ents #28
Conversation
O-Mutt
force-pushed
the
feat/orgsandents
branch
2 times, most recently
from
fdd1d13 to
6f43cc6
Compare
O-Mutt
force-pushed
the
feat/orgsandents
branch
from
6f43cc6 to
7246e8f
Compare
|
This particular solved our issue of letting us use org-scoped runners, thank you @O-Mutt for the PR. |
|
Happy to help, hopefully the change gets merged too |
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
this is great and exactly what I need - probably going to fork the repo just to integrate this PR and have it available on a SHA I control for use on Anki-Android unless/until it's merged
@jimmygchen this looks great to me, for whatever that's worth
| | ----------------- | ---------------------------------------------------------------------------------------------------------- | | ||
| | `github-token` | A token that can access the `list action runners` for the given context (e.g. user repo, org, enterprise). | | ||
| | `primary-runner` | A comma separated list of labels for the _primary_ runner (e.g. 'self-hosted,linux'). | | ||
| | `fallback-runner` | A comma separated list of labels for the _fallback_ runner (e.g. 'self-hosted,linux'). | |
There was a problem hiding this comment.
better to suggest a different fallback vs primary? even though this is just nitpicking on an example blurb
then as a concrete suggestion, I suspect the typical use case is to fallback to a public runner if self-hosted is offline
| | `fallback-runner` | A comma separated list of labels for the _fallback_ runner (e.g. 'self-hosted,linux'). | | |
| | `fallback-runner` | A comma separated list of labels for the _fallback_ runner (e.g. 'ubuntu-latest'). | |
|
|
||
| await checkRunner({ | ||
| token: "fake-token", | ||
| apiPath: 'orgs/call-me-ishmael/actions/runners', |
There was a problem hiding this comment.
sailing forbidden seas, and landing on barbarous coasts, I see
a gentleman and a scholar :-)
3 participants
This change is required based on the enterprise and organization implementations for listing self-hosted runners.
This adds two new, optional, mutually exclusive, inputs: enterprise and organization. We use these inputs to trigger which api we should be calling. The rest should be unchanged