-
Notifications
You must be signed in to change notification settings - Fork 30
Fix Clippy #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix Clippy #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses Clippy linting warnings by modernizing string formatting syntax and cleaning up imports across the codebase. The changes convert old-style formatted string macros to use inline variable interpolation, reorganize imports according to Rust conventions, and update error handling to use boxed types for large error enums.
Key changes:
- Modernized all
println!("{}", var)toprintln!("{var}")and similar patterns across all logging macros - Removed unused
clapimports (arg,command) and reordered imports to follow Rust conventions (std before external crates) - Updated error types in
sdk/src/models/errors.rsto wrapClientErrorinBox<>to reduce enum size, with a customFromimplementation
Reviewed changes
Copilot reviewed 73 out of 73 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/validator-history-cli/src/main.rs | Modernized string formatting in println statements and reordered imports |
| utils/validator-history-cli/src/commands/cranks/copy_gossip_contact_info.rs | Updated error! macro calls to use inline formatting |
| utils/validator-history-cli/src/commands/backfill_validator_age.rs | Modernized string formatting and removed unused clap imports |
| utils/steward-cli/src/utils/transactions.rs | Updated all println! and error logging to use inline formatting |
| utils/steward-cli/src/main.rs | Updated eprintln! to use inline formatting |
| utils/steward-cli/src/commands/init/*.rs | Modernized string formatting in println statements across all init commands |
| utils/steward-cli/src/commands/info/*.rs | Updated string formatting in all info/view commands |
| utils/steward-cli/src/commands/cranks/*.rs | Modernized string formatting across all crank commands |
| utils/steward-cli/src/commands/actions/*.rs | Updated string formatting and error messages across all action commands |
| utils/steward-cli/src/commands/command_args.rs | Reordered imports and removed unused clap imports |
| utils/steward-cli/src/cli_signer.rs | Updated error and println formatting |
| tests/tests/steward/test_steward.rs | Modernized assertion message formatting |
| tests/tests/steward/test_spl_passthrough.rs | Removed unused variable assignments and imports |
| tests/tests/steward/test_migrate_state_to_v2.rs | Updated assertion messages and error logging formatting |
| tests/tests/steward/test_integration.rs | Modernized println formatting and removed unused variables |
| tests/tests/steward/test_algorithms.rs | Updated println! and assertion message formatting |
| tests/src/validator_history_fixtures.rs | Modernized panic! and println! formatting |
| tests/src/steward_fixtures.rs | Updated panic! message formatting |
| sdk/src/utils/transactions.rs | Extensively updated all logging, error messages, and println statements to use inline formatting; changed ClientError wrapping |
| sdk/src/utils/debug.rs | Modernized println! formatting |
| sdk/src/utils/accounts.rs | Updated error message formatting throughout |
| sdk/src/models/errors.rs | Wrapped ClientError in Box<> with custom From implementation, removed unused log import and duplicate error variant |
| keepers/stakenet-keeper/src/state/keeper_config.rs | Removed unused clap imports |
| keepers/stakenet-keeper/src/operations/*.rs | Updated all logging macros to use inline formatting |
| keepers/stakenet-keeper/src/main.rs | Modernized info! and error! macro calls |
| keepers/stakenet-keeper/src/entries/crank_steward.rs | Updated all error! and info! logging to use inline formatting |
| .github/workflows/build.yaml | Removed pinned nightly toolchain setup for lint job and changed udeps to use unpinned nightly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.