remotecontrol: Move to context-aware robotjs fork for electron 14+ #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csett86
force-pushed
the
robotjs-context-aware
branch
from
ae63bbd to
950a0c3
Compare
saghul
reviewed
Nov 4, 2021
Member
|
LGTM, minue the downgrade in package-lock |
Member
Author
|
Agree, the downgrade was due to the #130 not being merged… will redo package-lock update later. |
csett86
force-pushed
the
robotjs-context-aware
branch
from
950a0c3 to
ade4188
Compare
Member
Author
|
Now with npm8, please review |
saghul
previously approved these changes
Nov 4, 2021
Member
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
LGTM, let's hope the failure was a fluke, I retried the job.
Member
Author
|
I am also locally checking if I can reproduce it in a win10 VM... To me the build failure looks reproducible, and the strange thing is that with npm6 and node12 it was working, and on all other platforms its also working... |
csett86
force-pushed
the
robotjs-context-aware
branch
4 times, most recently
from
b0a8c02 to
22f3c19
Compare
csett86
force-pushed
the
robotjs-context-aware
branch
from
eba941a to
368fcde
Compare
Member
Author
|
I finally found and fixed the error: prebuild has a dependency on node-gyp, which was then too old and failing with the non-descript erros. Updating prebuild (in the robotjs fork) helped. |
Member
|
Wonderful! |
saghul
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be reverted as soon as octalmage/robotjs#696
is merged upstream.