fix(AsyncQueue): call the callback only if it's a function (#2370) #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
|
Was the callback undefined? |
|
Yes it was. In several places some tasks are pushed into the queue with no callback. |
|
Then I think using optional chaining would look cleaner: func?.(arg); |
|
I wanted to cover as many cases as possible but I guess it's overkilling it. I'm changing for optional chaining |
athouary
force-pushed
the
async-queue-task-callback-may-be-undefined
branch
from
d9c708d
to
56452eb
Compare
athouary
force-pushed
the
async-queue-task-callback-may-be-undefined
branch
from
56452eb
to
638e2c0
Compare
|
Jenkins please test this please. |
saghul
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my PR for #2370, I ran into
TypeErrors in my console where the task callback was called without being defined. The error is caught and logged so it's not critical, but it pollutes the console.