fix: infinite loops in iter when interval is undefined#494
Open
theninadoge wants to merge 1 commit into
Open
Conversation
ThomasMayor
added a commit
to agendach/rrule
that referenced
this pull request
Apr 24, 2026
Prevents infinite loop in iter when callers spread options objects where
interval can be undefined at runtime (e.g. { ...opts, interval: form.val }
where form.val is unset). RFC 5545 specifies interval as a positive
integer, so default to 1 if missing.
Cherry-pick of jkbrzt#494
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #481.
The issue can be reproduced by create an rrule with an interval of undefined or null (overwriting the default 1), and then calling
after,between,beforeiCalendar RFC states that interval should be a positive integer, so this fix ensures that if not present interval is set back to the default of 1.
Thanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
mastercommitaddressing