94 crptg1 code quality increase #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonymDavid
requested review from
mesmatyi and
gfigneczi1
and removed request for
mesmatyi
mesmatyi
approved these changes
Jan 20, 2025
mesmatyi
approved these changes
Feb 4, 2025
gfigneczi1
approved these changes
Feb 6, 2025
| /ctrl/long/axMin: -40.0 | ||
| /ctrl/long/jxMax: 1.0 | ||
| /ctrl/long/jxMin: -1.0 | ||
|
|
| @@ -11,7 +11,7 @@ std::vector<float> crp::apl::GeometricPathCalculation::calculateCurvature(const | |||
| curvature.push_back(0.0f); | |||
| orientation.push_back(0.0f); | |||
| } | |||
| for (int i=1; i<x.size(); i++) | |||
| for (unsigned int i=1; i<x.size(); i++) | |||
| @@ -60,15 +60,15 @@ void crp::apl::WrapperBase::targetSpaceCallback(const crp_msgs::msg::TargetSpace | |||
| // calculating the curvature | |||
| std::vector<float> x; | |||
| std::vector<float> y; | |||
| for (int i=0; i<m_input.path.pathPoints.size(); i++) | |||
| for (unsigned int i=0; i<m_input.path.pathPoints.size(); i++) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup according to coding rules + removed old dependencies